Project

General

Profile

Actions

Bug #7436

closed

Architecture #7155: Stable class identifier

Architecture #7156: Modify generic methods to define and use the new class_prefix

Techniques that call _logger, _logger_default or logger_rudder will break because these methods take 4 arguments now and no upgrade path has been planned

Added by Nicolas CHARLES over 8 years ago. Updated over 2 years ago.

Status:
Released
Priority:
1
Category:
-
Target version:
-
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

When I create a Technique with classes condition, I get the following error

⇨ /var/rudder/share/3f39d51b-e66c-4781-bf7c-d07dca05982d/share/4656cf7a-1574-4d02-84ff-fa88b9f3a237/rules.new/cfengine-nova/Network_configuration/1.0/rudder_reporting.cf:7:0: error: Conflicting arity in calling bundle logger_rudder, expected 4 arguments, 2 given
⇨ /var/rudder/share/3f39d51b-e66c-4781-bf7c-d07dca05982d/share/4656cf7a-1574-4d02-84ff-fa88b9f3a237/rules.new/cfengine-nova/Network_configuration/1.0/rudder_reporting.cf:11:0: error: Conflicting arity in calling bundle logger_rudder, expected 4 arguments, 2 given

:(


Related issues 1 (0 open1 closed)

Related to Rudder - User story #7444: Update ncf.conf to use use new logger_rudder producing unique reporting ReleasedJonathan CLARKE2015-11-23Actions
Actions #1

Updated by Jonathan CLARKE over 8 years ago

  • Related to Architecture #7156: Modify generic methods to define and use the new class_prefix added
Actions #2

Updated by Jonathan CLARKE over 8 years ago

  • Project changed from Rudder to 41
  • Category deleted (Web - Technique editor)
  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
  • Target version changed from 3.2.0~beta1 to master

Actually, this has revealed a larger problem for version compatibility in ncf: the logger method was changed from 2 to 4 arguments, which means any existing calls and methods will no longer be valid, and these errors will appear for anyone who already has Rudder techniques using result_na, or any home-made generic methods.

We have therefore decided to restore the old signature for _logger and logger_rudder, and rename the new ones _log and log_rudder. The old names will just be wrappers for the new ones, and will disappear in time.

Actions #3

Updated by Jonathan CLARKE over 8 years ago

  • Subject changed from Error when generating Techniques with result_na to Techniques that call _logger, _logger_default or logger_rudder will break because these methods take 4 arguments now and no upgrade path has been planned
Actions #4

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/269
Actions #5

Updated by Benoît PECCATTE over 8 years ago

  • Blocks User story #7444: Update ncf.conf to use use new logger_rudder producing unique reporting added
Actions #6

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:54129bf650059cf059a1246fff6776fca190b992.

Actions #7

Updated by Benoît PECCATTE over 8 years ago

Applied in changeset commit:30219f78653c5e9038f7786c386d8352e2cc7bf0.

Actions #8

Updated by Jonathan CLARKE over 8 years ago

  • Related to deleted (Architecture #7156: Modify generic methods to define and use the new class_prefix)
Actions #9

Updated by Jonathan CLARKE over 8 years ago

  • Parent task set to #7156
Actions #10

Updated by Vincent MEMBRÉ over 8 years ago

  • Blocks deleted (User story #7444: Update ncf.conf to use use new logger_rudder producing unique reporting )
Actions #11

Updated by Vincent MEMBRÉ over 8 years ago

  • Related to User story #7444: Update ncf.conf to use use new logger_rudder producing unique reporting added
Actions #12

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending release to Released
Actions

Also available in: Atom PDF