Project

General

Profile

Actions

Bug #7412

closed

Architecture #7114: Make the bundlesequence be defined in a dedicated bundle

Inputs lists are weirdly indented and don't follow our CFEngine conventions when generated by rudder-web

Added by Jonathan CLARKE over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
N/A
Category:
System integration
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

As you can see in this generated file, the current generation does something odd with line indentation:

body file control {

  inputs => {
    "filesPermissions/2.1/filesPermissions.cf",
                  "rpmPackageInstallation/7.0/rpmPackageInstallation.cf",
                  "checkGenericFileContent/7.0/checkGenericFileContent.cf" 

  };

Furthermore, the inputs list starts on the same line as the first item, which is not standard in CFEngine.

This fix requires 2 pull requests: one in rudder to change the generation and one in rudder-techniques to change the template. They can be merged separately without risk.


Subtasks 1 (0 open1 closed)

Bug #7413: Fix CFEngine conventions for generated files rudder_directives.cf and rudder_system_directives.cfReleasedNicolas CHARLES2015-11-13Actions
Actions #1

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from New to In progress
Actions #2

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/962
Actions #3

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #5

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.2.0~beta1 which was released today.

Actions

Also available in: Atom PDF