Project

General

Profile

Actions

Bug #6291

closed

Zypper hangs on dialogs / issues due to open tty

Added by Florian Heigl about 9 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

There's a few places where we're calling zypper.
Zypper notices that there's an open tty and runs in interactive mode.
The result is when you have unavailable repositories or key issues (i.e. nightly rudder repos) or anything else that could use manual input, zypper will stop with the relevant dialog.

i.e. in cfengine stdlib:
$ grep -R "zypper pat" *
initial-promises/node-server/common/1.0/cfengine_stdlib.cf: package_patch_list_command => "/usr/bin/zypper patches";
initial-promises/node-server/common/1.0/cfengine_stdlib.cf: package_patch_list_command => "/usr/bin/zypper patches"

same goes with most of the other techniques.

There is a --non-interactive flag, which (great) comes with safe defaults; this could be easily used, otherwise one could also try closing the tty.

Actions #1

Updated by Nicolas CHARLES about 9 years ago

  • Status changed from New to Discussion
  • Assignee set to Florian Heigl

Florian,

The Technique rpmPackageInstallation alreay uses --non-interactive parameter, as well as ncf
In the initial promises, we are using the package_method generic, that also uses --non-interactive

Do you have specific example where we use zypper in non-interactive mode ?

Just as a remark, we don't use most of the bundles in the cfengine standart librairy; they are there, but we just don't need them

Actions #2

Updated by Nicolas CHARLES about 9 years ago

Oh, if the non-interactive mode is used, and the repository is not signed, zypper complains about not having tty
Could it be this issue that you are encoutering ?

Actions #3

Updated by Benoît PECCATTE almost 8 years ago

  • Target version set to 2.11.21
Actions #4

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions #5

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions #6

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions #7

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.24 to 308
Actions #8

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 308 to 3.1.14
Actions #9

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions #10

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions #11

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions #12

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions #13

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions #14

Updated by Jonathan CLARKE about 7 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Getting started - demo | first install | level 1 Techniques
Actions #15

Updated by Benoît PECCATTE about 7 years ago

  • Priority set to 45
Actions #16

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.19 to 3.1.20
Actions #17

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from Discussion to New
  • Assignee deleted (Florian Heigl)
Actions #18

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.20 to 3.1.21
Actions #19

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.21 to 3.1.22
Actions #20

Updated by Benoît PECCATTE almost 7 years ago

  • Priority changed from 45 to 58
Actions #21

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.22 to 3.1.23
Actions #22

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.23 to 3.1.24
Actions #23

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.24 to 3.1.25
Actions #24

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.25 to 387
Actions #25

Updated by Alexis Mousset over 6 years ago

  • Project changed from Rudder to 41
  • Category changed from System integration to Generic methods - Package Management
  • Assignee set to Alexis Mousset
  • Target version changed from 387 to 4.1.10

It seems we are not calling zypper with non-interactive everywhere.

Actions #26

Updated by Alexis Mousset over 6 years ago

  • Status changed from New to In progress
Actions #27

Updated by Alexis Mousset over 6 years ago

  • In package_install/remove/check we use the ncf_generic* bundles which are fixed by this PR
  • In the technique and package_present/absent we use the zypper package module wich already has the non-interactive option
  • In the deprecated technique we already have non-interactive option
Actions #28

Updated by Alexis Mousset over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/671
Actions #29

Updated by Alexis Mousset over 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:745115646af072779adafdf3c5a0921f022eb13b.

Actions #30

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.

Actions #31

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods - Package Management to Generic methods
  • Priority changed from 58 to 0
Actions

Also available in: Atom PDF