Project

General

Profile

Actions

User story #5665

closed

User story #5673: Add support to parameters in ncf techniques written with ncf builder

Generate technique with parameter from ncf

Added by François ARMAND over 9 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

We want to manage techniques from ncf, we have to do it for two things:

  • Generate metadata.xml and files for agent (dsc will be in another issue)
  • Modify generation to be able to generate correct bundle calls for our Directives

A small example of what we want
Let you have a technique "add_user" with 2 parameters:

bundle agent add_user(user_name, home_path)

This needs to create a technique with a Parameter Secion in metadata.xml with 2 simple inputs:

=> Two Input for variable USER_NAME and HOME_PATH

and a directive implementing this technique with parameters "toto" and "/home/toto".

We want to generate the following bundle call:

"Directive name" => add_user("toto","/home/toto")

Subtasks 4 (0 open4 closed)

Bug #5666: Directive form is laways empty when REPORTKEYS is presentRejected2014-10-21Actions
User story #5668: Include directive parameter in expected report substitution logicRejectedActions
Bug #5711: metadata.xml is considered malformed if it contains reportkeys and componentkeyRejected2014-10-29Actions
User story #5721: Add a REF element to REPORTKEYSRejectedFrançois ARMANDActions

Related issues 1 (0 open1 closed)

Blocked by Rudder - User story #5400: Use the existence of expected_reports.csv to detect if a technique is from ncfReleasedNicolas CHARLES2014-11-04Actions
Actions #1

Updated by François ARMAND over 9 years ago

  • Project changed from 41 to Rudder
  • Category set to Web - Config management
  • Target version set to 140
Actions #2

Updated by Matthieu CERDA over 9 years ago

  • Target version changed from 140 to 3.0.0~beta1
Actions #3

Updated by Jonathan CLARKE over 9 years ago

  • Target version changed from 3.0.0~beta1 to 3.1.0~beta1
Actions #4

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 3.1.0~beta1 to 3.1.0~rc1
Actions #5

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 3.1.0~rc1 to 3.1.0
Actions #6

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 3.1.0 to 3.1.1
Actions #7

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 3.1.1 to 3.1.2
Actions #8

Updated by Jonathan CLARKE over 8 years ago

  • Target version changed from 3.1.2 to Ideas (not version specific)
Actions #9

Updated by Vincent MEMBRÉ over 6 years ago

  • Related to deleted (User story #5673: Add support to parameters in ncf techniques written with ncf builder)
Actions #10

Updated by Vincent MEMBRÉ over 6 years ago

  • Parent task set to #5673
Actions #11

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from Ideas (not version specific) to 4.3.0~beta1
Actions #12

Updated by Vincent MEMBRÉ over 6 years ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions #13

Updated by Vincent MEMBRÉ over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/1820
Actions #14

Updated by Vincent MEMBRÉ about 6 years ago

  • Subject changed from Adapt Rudder to allows to have ncf technique with parameter to Generate technique with parameter from ncf
  • Description updated (diff)
Actions #15

Updated by François ARMAND about 6 years ago

This seems good until we don't have more complexe parameters for ncf technique (i.e: arrays, multi-valued section, etc).
Here, we have the limitation that the parameters are written directly in the bundle sequence, and so we can't pass more complexe things than strings.

What we want to do in the next iteration is to have all directives generated from technique from technique editor to put there parameters in a "parameters.json" file, with roughtly that format:

{
  "directiveid (or reportid?) 1": { "paramName1": "simple param" , "paramName2": { "structured"} etc
, "directiveid (or reportid?) 2": { "paramName1": "simple param" , "paramName2": { "structured"} etc
}

And then only give the directiveid (or reportid) as parameter of the bundle in the bundle sequence.

Actions #16

Updated by Rudder Quality Assistant about 6 years ago

  • Assignee changed from François ARMAND to Vincent MEMBRÉ
Actions #17

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending technical review to Pending release
Actions #18

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.0~beta1 which was released today.

Actions

Also available in: Atom PDF