Project

General

Profile

Actions

Bug #5521

closed

Force copy of tools folder if any mandatory files are not there

Added by Nicolas CHARLES over 9 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
N/A
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

If any of the mandatory files in the tools folder is missing, then we should copy all the folder.

List of mandatory files would be:
- check_rsyslog_version, on linux
- list-compatible-inputs, on Unix/Android ?
- iconv.exe and userlist.bat on windows
- send-clen.sh on Unix/Android
- getDate.bat and centreon-e2s.exe on Windows

this list is probably not exhaustive though
Jon, do you know of any other mandatory file ?

Actions #1

Updated by Jonathan CLARKE over 9 years ago

When we discussed this this morning, we agreed it was not necessary to force a copy based on specific files if we implemented a timestamp based check to copy tools. This is done now (in a related ticket) so I see no reason to implement this.

Why did you change your mind? Did I miss something?

Actions #2

Updated by Nicolas CHARLES over 9 years ago

I think we did agree that if any of these file where missing, we should override the timestamp based machanism.

Actions #3

Updated by Jonathan CLARKE over 9 years ago

That was our original idea, then we came up with the timestamp approach.

Why do you think this would not be reliable?

If you think we should be more cautious, how about adding a check that the tools directory contains more than 0 files? I'd rather avoid maintaining a list of files.

Actions #4

Updated by Matthieu CERDA over 9 years ago

  • Target version changed from 2.10.6 to 2.10.7
Actions #5

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.7 to 2.10.8
Actions #6

Updated by Jonathan CLARKE over 9 years ago

  • Status changed from New to Rejected

This doesn't seem to be causing any trouble, and no response, so rejecting. Feel free to re-open if necessary.

Actions

Also available in: Atom PDF