Project

General

Profile

Actions
Copy link

Bug #5165

closed

User story #2114: Integrate ncf-builder in Rudder

User story #5093: Package ncf-api-virtualenv

Bug #5164: Fix ncf-api-virtualenv

The virtualenv cleaning statement in ncf-api-virtualenv debian packages matches too much things

Added by Matthieu CERDA almost 10 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
1
Assignee:
Jonathan CLARKE
Category:
-
Target version:
2.11.0~beta2
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Currently, it looks like this:

    cd SOURCES && for i in easy_install python pip; do rm -f ncf-api-virtualenv/bin/${i}*; done

It will not work, as ${i} in a Makefile would expand to nothing, and will actually completely tidy ncf-api-virtualenv/bin/ 3 times in a row :)

The right statement is:

    cd SOURCES && for i in easy_install python pip; do rm -f ncf-api-virtualenv/bin/$${i}*; done

Actions
Copy link
 #1

Updated by Matthieu CERDA almost 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/414

PR is ready !

Actions
Copy link
 #2

Updated by Matthieu CERDA almost 10 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:6f1d813531cfafd0585491a1b915a8e8669fa07d.

Actions
Copy link
 #3

Updated by Jonathan CLARKE almost 10 years ago

Applied in changeset commit:158bcaeff6347a63efbed4dbb360dc4f4305b066.

Actions
Copy link
 #4

Updated by Vincent MEMBRÉ almost 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.0~beta2 (announcement , changelog), which were released today.

Actions
Copy link

Also available in: Atom PDF