Project

General

Profile

Actions

Bug #4555

closed

Missing body in update.cf in system techniques to copy files from ncf

Added by Jonathan CLARKE about 10 years ago. Updated about 10 years ago.

Status:
Released
Priority:
1
Assignee:
Matthieu CERDA
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The PR that fixed #4384 introduces a bug, the body copy_digest_without_perms is missing:

⇨ cf-promise check fails for promises generated at '/var/rudder/cfengine-community/inputs.new'
⇨ /var/rudder/cfengine-community/inputs.new/common/1.0/update.cf:147:0: error: Undefined body copy_digest_without_perms with type copy_from
⇨ /var/rudder/cfengine-community/inputs.new/common/1.0/update.cf:155:0: error: Undefined body copy_digest_without_perms with type copy_from

Indeed, this body is never added by the PR. I'll add it now.

#4384 only affects branches 2.9+ because ncf was introduced in 2.9.*.

Actions #1

Updated by Jonathan CLARKE about 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/309

PR available for review : https://github.com/Normation/rudder-techniques/pull/309

Given Nicolas' unavailability, please review Matthieu.

Actions #2

Updated by Jonathan CLARKE about 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:bef1ff99e9287c64899aba2107c5b191b543f7b5.

Actions #3

Updated by Matthieu CERDA about 10 years ago

Applied in changeset policy-templates:commit:2204902336f0ac55089386a0da1b00c89669febb.

Actions #4

Updated by Vincent MEMBRÉ about 10 years ago

  • Subject changed from Missing body in update.cf in system techniques (introduced by fix for #4384 - enforce permissions on ncf file copies) to Missing body in update.cf in system techniques to copy files from ncf
Actions #5

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.9.3, which was released today.
Check out:

Actions

Also available in: Atom PDF