Project

General

Profile

Actions

Bug #4302

closed

Directive based on a modified Technique should be saved.

Added by François ARMAND over 10 years ago. Updated over 7 years ago.

Status:
Rejected
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

With ticket #4289, we saw that when a metatechnique change (i.e: is commited into the repository), then we must also save back all directives based on it.

This is exacerbated with metatechnique because we don't update their version on each change AND almost all change leads to a modification of the metadata.xml AND these modifications are related to variables AND these variable values are used in reporting so that the absence of a directive change leads to a missing report value in the LDAP object of the directive.

But the same kind of problem could be found in regular technique, if the metadata.xml is modified to add some variable whose value will be used in reports. So shouldn't we backport the logic of the correction in #4289 into version of Rudder older than 2.9.0 ?

Note: we didn't handled that case for now, using the argument: it's not a supported use case, if you want to change the metadata.xml, either use a different version or assume the consequences of your choice.


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #4289: When a Technique is updated, Directives based on that Technique are not updatedReleasedFrançois ARMAND2013-12-26Actions
Actions #1

Updated by Nicolas CHARLES over 10 years ago

  • Assignee changed from Nicolas CHARLES to François ARMAND

I'm really not sure it should be fixed for "traditionnal" techniques, as they have a different workflow than "meta-techniques with no parametrizables values"

What do you reckon would be the use case of changing metadata.xml content for normal techniques ?

Actions #2

Updated by François ARMAND over 10 years ago

  • Assignee changed from François ARMAND to Nicolas CHARLES

Nicolas CHARLES wrote:

I'm really not sure it should be fixed for "traditionnal" techniques, as they have a different workflow than "meta-techniques with no parametrizables values"

What do you reckon would be the use case of changing metadata.xml content for normal techniques ?

Adding/removing section and variables, essentially. Today, we are saying: "that's an unsupported use case, you have to also update the version number for that". But actually, if somebody DO do that, the result is a broken Rudder (no more promise regeneration working due to missing parameters). And so, the user will have to go to each directive based on that technique to save them again before being able to do anything else.

So it would also help in that case: we can (and should) still say: "you really should NOT change metadata.xml without changing the technique version", but at least handle more automatically certain case (variable with default value).

Actions #3

Updated by Vincent MEMBRÉ over 10 years ago

  • Target version changed from 2.8.2 to 2.8.3
Actions #4

Updated by Nicolas CHARLES over 10 years ago

François ARMAND wrote:

Nicolas CHARLES wrote:

I'm really not sure it should be fixed for "traditionnal" techniques, as they have a different workflow than "meta-techniques with no parametrizables values"

What do you reckon would be the use case of changing metadata.xml content for normal techniques ?

Adding/removing section and variables, essentially. Today, we are saying: "that's an unsupported use case, you have to also update the version number for that". But actually, if somebody DO do that, the result is a broken Rudder (no more promise regeneration working due to missing parameters). And so, the user will have to go to each directive based on that technique to save them again before being able to do anything else.

I'm really not sure we should permit users to add variables in a technique (normal) without changing version number. The risks is high that the values in Directives would not correspond to the values the user expects (or worse, that it might go against what the system needs).

So it would also help in that case: we can (and should) still say: "you really should NOT change metadata.xml without changing the technique version", but at least handle more automatically certain case (variable with default value).

Actions #5

Updated by François ARMAND over 10 years ago

How do you want to prevent the user to edit a file and commit it?

All that is to try to enhanced a case that is clearly NOT RECOMMENDED in the doc, and where we try to mitigate the problems.

Actions #6

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.8.3 to 2.8.4
Actions #7

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.8.4 to 133
Actions #8

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 133 to 2.9.5
Actions #9

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.9.5 to 2.9.6
Actions #10

Updated by Jonathan CLARKE almost 10 years ago

  • Target version changed from 2.9.6 to 2.9.7
Actions #11

Updated by Jonathan CLARKE almost 10 years ago

  • Target version changed from 2.9.7 to 150
Actions #12

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 150 to 2.10.4
Actions #13

Updated by Nicolas PERRON over 9 years ago

  • Target version changed from 2.10.4 to 2.10.5
Actions #14

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.5 to 2.10.6
Actions #15

Updated by Matthieu CERDA over 9 years ago

  • Target version changed from 2.10.6 to 2.10.7
Actions #16

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.7 to 2.10.8
Actions #17

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.8 to 2.10.9
Actions #18

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.9 to 2.10.10
Actions #19

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.10 to 2.10.11
Actions #20

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.11 to 2.10.12
Actions #21

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.12 to 2.10.13
Actions #22

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.13 to 2.10.14
Actions #23

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.14 to 2.10.15
Actions #24

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.15 to 2.10.16
Actions #25

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.16 to 2.10.17
Actions #26

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.17 to 2.10.18
Actions #27

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.18 to 2.10.19
Actions #28

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.19 to 2.10.20
Actions #29

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.20 to 2.11.18
Actions #30

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.18 to 2.11.19
Actions #31

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.19 to 2.11.20
Actions #32

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.20 to 2.11.21
Actions #33

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions #34

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions #35

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions #36

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.24 to 308
Actions #37

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 308 to 3.1.14
Actions #38

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions #39

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions #40

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions #41

Updated by François ARMAND over 7 years ago

  • Status changed from Discussion to Rejected

"Rudder version older than 2.9.0" is long ended story. Closing that one.

Actions

Also available in: Atom PDF