Bug #4282: Directive migration doesn't handle default values - Rudder - Issue Tracker

Actions

Copy link

Bug #4282

closed

User story #4293: Migrating from a Technique version to another one in a Directive is long and painful

Directive migration doesn't handle default values

Added by Dennis Cabooter over 10 years ago. Updated about 8 years ago.

Status:

Released

Priority:

Assignee:

François ARMAND

Category:

Web - Config management

Target version:

2.11.19

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

MOTD configuration technique forces useless option

The form contains some errors, please correct them.
'Where should this text be added in the MOTD' field must not be empty

It's useless here to tell if the text should be added at the beginning or end, since I already set "Enforce this MOTD only" to "Yes".

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Dennis Cabooter over 10 years ago

I fogot to say I'm talking about version 3.0 of the MOTD technique.

Actions

Copy link

Updated by Matthieu CERDA over 10 years ago

Category set to Techniques
Status changed from New to 8
Assignee set to Matthieu CERDA
Priority changed from N/A to 4
Target version set to 2.6.10

Qualifying this. Thanks for reporting Dennis :)

Actions

Copy link

Updated by Jonathan CLARKE over 10 years ago

Status changed from 8 to Discussion
Assignee changed from Matthieu CERDA to Dennis Cabooter

Dennis Cabooter wrote:

MOTD configuration technique forces useless option

[...]

It's useless here to tell if the text should be added at the beginning or end, since I already set "Enforce this MOTD only" to "Yes".

I am confused. This option is a boolean option (two choices), and there is a default value. How did you manage to have no values selected?

Did this happen while migrating from an older version, by any chance?

Actions

Copy link

Updated by Jonathan CLARKE over 10 years ago

Assignee changed from Dennis Cabooter to François ARMAND

Jonathan CLARKE wrote:

Dennis Cabooter wrote:

MOTD configuration technique forces useless option

[...]

It's useless here to tell if the text should be added at the beginning or end, since I already set "Enforce this MOTD only" to "Yes".

I am confused. This option is a boolean option (two choices), and there is a default value. How did you manage to have no values selected?

Did this happen while migrating from an older version, by any chance?

Aha, I just tested myself (sorry, should have done that first, before asking you Dennis!) and this does indeed happen when migrating from an older version. In that case, the default value is not applied!

In my opinion, this is therefore not a Technique bug (we can't make a SELECT1 variable non mandatory, this doesn't make any sense).

François, over to you to decide how to handle this. I think we should change Directive version migation to honour default values, but highlight which variables are new to the user in the form, so it's easy for him/her to validate the default values.

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Target version changed from 2.6.10 to 2.6.11

Actions

Copy link

Updated by Jonathan CLARKE over 10 years ago

Subject changed from MOTD configuration technique forces useless option to Directive migration doesn't handle default values
Category changed from Techniques to Web - Config management
Priority changed from 4 to 2

Updating the subject to clarify.

François, what's your opinion here?

Actions

Copy link

Updated by Vincent MEMBRÉ about 10 years ago

Target version changed from 2.6.11 to 2.6.12

Actions

Copy link

Updated by Vincent MEMBRÉ about 10 years ago

Target version changed from 2.6.12 to 2.6.13

Actions

Copy link

Updated by Vincent MEMBRÉ almost 10 years ago

Target version changed from 2.6.13 to 2.6.14

Actions

Copy link

#10

Updated by Jonathan CLARKE almost 10 years ago

Target version changed from 2.6.14 to 2.6.16

Actions

Copy link

#11

Updated by Jonathan CLARKE almost 10 years ago

Target version changed from 2.6.16 to 2.6.17

Actions

Copy link

#12

Updated by Nicolas PERRON over 9 years ago

Target version changed from 2.6.17 to 2.6.18

Actions

Copy link

#13

Updated by Matthieu CERDA over 9 years ago

Target version changed from 2.6.18 to 2.6.19

Actions

Copy link

#14

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 2.6.19 to 2.6.20

Actions

Copy link

#15

Updated by François ARMAND over 9 years ago

Target version changed from 2.6.20 to 2.10.9

Jonathan CLARKE wrote:

François, over to you to decide how to handle this. I think we should change Directive version migation to honour default values, but highlight which variables are new to the user in the form, so it's easy for him/her to validate the default values.

Yes, it's the only sane thing to do.

Actions

Copy link

#16