Project

General

Profile

Actions

Bug #4062

closed

Rudder upgrade fails if you accept to replace rudder-web.properties with new default one.

Added by Dennis Cabooter over 10 years ago. Updated over 10 years ago.

Status:
Released
Priority:
2
Category:
-
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I get a post-installation error upgrading rudder-server-root 2.6 -> 2.7:

INFO: Checking LDAP service status............LDAP service verification failed after 10 tries. Aborting the migration.
Please restart the Rudder service, and start the migration script again:
# /etc/init.d/rudder-server-root restart
# /opt/rudder/bin/rudder-upgrade
dpkg: error processing rudder-webapp (--configure):
 subprocess installed post-installation script returned error exit status 1
[master cddc1e6] committing changes in /etc after apt run
 Author: decab <decab@winzsv015.wintershall.nl>
 3 files changed, 139 insertions(+), 72 deletions(-)
 rewrite apache2/sites-available/rudder-default (97%)
E: Sub-process /usr/bin/dpkg returned an error code (1)

I tried the provided suggestion, and it looks like that works:

 * Stopping PostgreSQL 9.1 database server                               [ OK ] 
slapd[19188]: [INFO] Using /etc/default/slapd for configuration
slapd[19193]: [INFO] Halting OpenLDAP...
slapd[19197]: [OK] OpenLDAP stopped after 1 seconds
slapd[19198]: [INFO] Launching OpenLDAP database backup...
slapd[19215]: [OK] data save in /var/rudder/ldap/backup/openldap-data-20131014131309.ldif
slapd[19217]: [INFO] Halting OpenLDAP replication...
slapd[19218]: [INFO] no replica found in configuration, aborting stopping slurpd
slapd[19230]: [INFO] Using /etc/default/slapd for configuration
slapd[19235]: [INFO] Launching OpenLDAP configuration test...
slapd[19237]: [OK] OpenLDAP configuration test successful
slapd[19238]: [INFO] Launching OpenLDAP replication...
slapd[19239]: [INFO] no replica found in configuration, aborting lauching slurpd
slapd[19240]: [INFO] no db_recover done
slapd[19241]: [INFO] Launching OpenLDAP...
slapd[19242]: [OK] file descriptor limit set to 1024
slapd[19249]: [OK] OpenLDAP started on port 389 and 636
 * Starting PostgreSQL 9.1 database server
Actions #1

Updated by Dennis Cabooter over 10 years ago

My mistake. Restarting worked. The rudder-upgrade script keeps failing on LDAP:

# /opt/rudder/bin/rudder-upgrade
INFO: Checking LDAP service status............LDAP service verification failed after 10 tries. Aborting the migration.
Please restart the Rudder service, and start the migration script again:
# /etc/init.d/rudder-server-root restart
# /opt/rudder/bin/rudder-upgrade
Actions #2

Updated by Dennis Cabooter over 10 years ago

The problem was with /opt/rudder/etc/rudder-web.properties. The installation asked me if I would overwrite the file. Since I don't know if other changed are made, I choosed to overwrite it, after I made a backup in /root. Changed back the passwords and everything now works fine.

Actions #3

Updated by Nicolas PERRON over 10 years ago

Ok, so the problem is that if the rudder-web.properties are replaced during upgrade of rudder-web package, the rudder-upgrade does not work ?

I suppose so, since the default rudder-web.properties does not contain the good the credentials.

Actions #4

Updated by Dennis Cabooter over 10 years ago

The installer will give you 3 choices:

- Ignore the package maintainer's version and keep your old one
- Overwrite your old one with the package maintainer's version
- Compare the changes from your old one with the package maintainer's version

I always choose to overwrite after backing up the old one first.

Actions #5

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from New to 8
  • Assignee set to Matthieu CERDA
  • Priority changed from N/A to 2

I think we should fix our upgrade scripts to ensure that passwords from rudder-passwords.conf are updated in rudder-webapp.properties before attempting any other checks. This can be annoying for upgrades.

Matthieu, please implement.

Actions #6

Updated by Nicolas CHARLES over 10 years ago

I think we should also fetch the define syslog port, or else all reporting may fail ?

It would be awesome to have a clear warning before the question, that says that Rudder handle the upgrade of this file, and that one should only choose to overwrite if wanting to restore defaults values for all parameters

Actions #7

Updated by Matthieu CERDA over 10 years ago

  • Status changed from 8 to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/168

PR available.

Actions #8

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA
  • Target version changed from 2.7.6 to 2.8.0~rc2

This PR looks good, but I consider the change to be too intrusive for 2.7. Let's include it in 2.8.

Actions #9

Updated by Matthieu CERDA over 10 years ago

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • Pull Request changed from https://github.com/Normation/rudder-packages/pull/168 to https://github.com/Normation/rudder-packages/pull/171

Retargetting complete, PR updated.

Actions #10

Updated by Matthieu CERDA over 10 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset packages:commit:124d7d85baad399b68e53d89101174057cf89bc2.

Actions #11

Updated by Anonymous over 10 years ago

Applied in changeset packages:commit:330a2a145dd95e4b47a8d080d0b3bf0d8c61e372.

Actions #12

Updated by Vincent MEMBRÉ over 10 years ago

  • Subject changed from Post-installation error upgrading rudder-server-root 2.6 -> 2.7 to Rudder upgrade fails if you accept to replace rudder-web.properties with new default one.
Actions #13

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.8.0~rc2, which was released today.
Check out:

Actions

Also available in: Atom PDF