Project

General

Profile

Actions

Bug #3781

closed

The XML parser which check metadata.xml of the Techniques display a wrong error message when the XML is malformed (Talk about SECTION when it is due to INPUTS)

Added by Nicolas PERRON over 10 years ago. Updated about 9 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The XML parser in cf-clerk does not always display the right error message when a metadata.xml is malformed. In my case, I had an useless tag </INPUTS> in the metadata.xml and the message error was:

11:35:47.586 [qtp760805843-117] ERROR com.normation.cfclerk.services.impl.GitTechniqueReader - Ignoring technique '/applications/[...]/2.0/metadata.xml' because the descriptor file is malformed. Error message was: Unexpected issue with the descriptor file /applications/[...]/2.0/metadata.xml: The element type "SECTION" must be terminated by the matching end-tag "</SECTION>".

Actions #1

Updated by Nicolas PERRON over 10 years ago

  • Target version changed from 2.4.7 to 2.4.8
Actions #2

Updated by Nicolas CHARLES over 10 years ago

I'm looking for a way to have proper error messages
Not sure i'll be able to

Actions #3

Updated by Nicolas CHARLES over 10 years ago

I can't do much more than listing the line and column error line, for the error message comes from the internal XML parser
the new error message is

ERROR com.normation.cfclerk.services.impl.GitTechniqueReader - Ignoring technique '/applications/apacheNegociationSSL/1.1/metadata.xml' because the descriptor file is malformed. Error message was: Unexpected issue with the descriptor file /applications/apacheNegociationSSL/1.1/metadata.xml at line 59, column 7: The element type "SECTION" must be terminated by the matching end-tag "</SECTION>" 

Actions #4

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/cf-clerk/pull/22
Actions #5

Updated by François ARMAND over 10 years ago

Adding these information are a really good idea! Thanks NicolasC for thinking to it :)

Actions #6

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset clerk:commit:5b0100755dd9984bbd547d9816d580ad09c3b2d3.

Actions #7

Updated by Anonymous over 10 years ago

Applied in changeset clerk:commit:dbe7f93ffb0c67b09ddbbd4b2131da0aabefd436.

Actions #8

Updated by Nicolas PERRON over 10 years ago

  • Subject changed from The XML parser display a wrong error message when the XML is malformed (Talk about SECTION when it is due to INPUTS) to The XML parser which check metadata.xml of the Techniques display a wrong error message when the XML is malformed (Talk about SECTION when it is due to INPUTS)
Actions #9

Updated by Nicolas PERRON over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.4.8, which was released today.
Check out:

Actions #10

Updated by Benoît PECCATTE about 9 years ago

  • Category changed from 14 to Web - Config management
Actions

Also available in: Atom PDF