Project

General

Profile

Actions

Bug #3186

closed

When we click on "update" and nothing changed, no event is generated

Added by Nicolas CHARLES about 11 years ago. Updated about 11 years ago.

Status:
Rejected
Priority:
N/A
Category:
Web - Maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I created a Group, and forgot to fill a change message. So after creating it, I filled in a Change message, and click on Update
Since nothing changed on the object (same node, same search), no event log was generated. But still, we has a deployment process started and finished immediatly, because of my action

This is a bit confusing when looking in the eventlog

Do you think it's the expected behaviour not to save an eventlog if nothing changed ?


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #3191: When nothing is modified in Directive/Rule/Group, a deployment is started nonethelessReleasedFrançois ARMAND2013-01-15Actions
Actions #1

Updated by Nicolas CHARLES about 11 years ago

  • Subject changed from When we click on 3update" and nothing changed, no event is generated to When we click on "update" and nothing changed, no event is generated
Actions #2

Updated by Jonathan CLARKE about 11 years ago

  • Status changed from Discussion to Rejected
This is the expected behaviour: if you don't change anything, there is no call for a change message. If you forgot your change message in the previous event, well, three options:
  1. You shouldn't have forgotten it :-)
  2. Enable the "mandatory" option for change messages, to enforce their entry in the UI
  3. We may need another feature, such as adding comments to Event logs, Groups, Directives, etc... to add information to existing objects/events.

Either way, what is most confusing here is that an event log is generated anyway, even though there is no change. This is caused by the promise regeneration. I think the best solution here is to not launch a promise generation if there were no changes (we clearly know how to detect this, since we don't log the event). This will be addressed in #3191.

Actions

Also available in: Atom PDF