Project

General

Profile

Actions

Architecture #2605

closed

rudder-techniques check script should detect illegal log level "log_error"

Added by Jonathan CLARKE almost 12 years ago. Updated about 9 years ago.

Status:
Released
Priority:
2
Category:
Packaging
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

Sometimes in Techniques it's tempting to use log level "log_error", when we should be using "result_error".

This should be detected and cause our test script to fail.

Actions #1

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:a0b1c4c889da1646103f388c2f311b5acc8230a8.

Actions #2

Updated by Nicolas PERRON almost 12 years ago

Seems OK but I think that it would be better if 'echo' could be located in function 'on_exit()' like the others

Actions #3

Updated by Jonathan CLARKE almost 12 years ago

  • Tracker changed from User story to Architecture
  • Status changed from Pending technical review to Released

Nicolas PERRON wrote:

Seems OK but I think that it would be better if 'echo' could be located in function 'on_exit()' like the others

Ah yes, about that. I deliberately changed style because I didn't understand why checks and their associated error messages were defined in seperate places. Could you fix the script the other way, to reassociate messages with their checks in "nearby" lines?

Actions #4

Updated by Nicolas PERRON about 11 years ago

  • Project changed from Rudder to 34
  • Category deleted (11)
Actions #5

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF