Project

General

Profile

Actions
Copy link

Bug #2456

closed

A disabled Policy Instance is still applied in the generated configuration

Added by Jonathan CLARKE almost 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
1
Assignee:
Nicolas CHARLES
Category:
Web - Config management
Target version:
2.3.7
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I just disabled one PI that is applied in a CR with 2 other PIs (so my CR has a total of 3 PI). However, the generated promises still include the info from that PI!

Actions
Copy link
 #1

Updated by Nicolas CHARLES almost 12 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by François ARMAND almost 12 years ago

  • Status changed from Pending technical review to Released

That seems OK, but it is highlighting a fundamental flow that I knew will it at one time or another: basically, we are fuzzing the semantic of Empty (a valid empty result) and Failure (an error).

To be strict, (and we are seing here that we should have), in several cases, our Box[Something] Should be Box[Option[Something]] to stay with the "empty = error" semantic of Lift.

So, let it be like that for now, but we should REALLY look to scalaz validation type1 in place of Box (Box let you do bad things).

[1] http://scalaz.googlecode.com/svn/continuous/latest/browse.sxr/scalaz/example/ExampleValidation.scala.html

Actions
Copy link

Also available in: Atom PDF