Project

General

Profile

Actions

Bug #2417

closed

checkGenericFileContent 2.1 is highly dubious

Added by Nicolas CHARLES almost 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
1
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

It used to be multin instance, it isn't anymore. This is highly dubious, since 2.0 is multivalued.
It's been mcreated by tickets 2140 and 2218, without any multi instance within...


Related issues 2 (0 open2 closed)

Related to Rudder - Bug #2218: PT checkGenericFileContent version 2.1 is completely broken!ReleasedNicolas CHARLES2012-01-30Actions
Related to Rudder - User story #2140: PT checkGenericFileContent : Add the possibility to delete or replace a line using a regexpReleasedMatthieu CERDA2011-12-22Actions
Actions #1

Updated by Jonathan CLARKE almost 12 years ago

  • Priority changed from N/A to 1
Actions #2

Updated by Matthieu CERDA almost 12 years ago

Actions #3

Updated by Matthieu CERDA almost 12 years ago

  • Status changed from New to Discussion
  • Assignee changed from Matthieu CERDA to Nicolas CHARLES
Actions #4

Updated by Nicolas CHARLES almost 12 years ago

The PT used to have a "Add another" button, which is not the case anymore

Previous version, as per commit ea8f29020bbe205615c751b180c5aaf5ece92288

<SECTION name="File to manage" multivalued="true">
<SECTION name="File" component="true" componentKey="GENERIC_FILE_CONTENT_PATH">

New version, in the repository

<SECTION name="File to manage">
<SECTION name="File" component="true">

So the version is far from being perfectly fine ...

Actions #5

Updated by Matthieu CERDA almost 12 years ago

  • Status changed from Discussion to In progress
  • % Done changed from 0 to 80

You are right NCH, but I just can't understand why this commit was not applied on this branch ... maybe a merge error !

Anyway, I cherry picked the commit, I will now test it on Orch-2.

Actions #6

Updated by Matthieu CERDA almost 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 80 to 100

With commit:ea8f29020bbe205615c751b180c5aaf5ece92288 , the "Add another" button is there and the PT behaves OK. I think I'm done here !

Actions #7

Updated by Nicolas PERRON almost 12 years ago

It seems OK

Actions #8

Updated by Nicolas CHARLES almost 12 years ago

  • Status changed from Pending technical review to Released

This looks correct, thank you

Actions

Also available in: Atom PDF