Project

General

Profile

Actions

User story #2399

closed

Change message for configuration changes

Added by François ARMAND almost 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
1
Category:
Web - Config management
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

We want to allow/force an user to add a change message describing why he just did what he did on a Technique/Directive/Rules/Group modification (and if possible when a user manually accept waiting changes).

The message would be asked in a pop-up. A Rudder configuration property must be added to allow to disabled the pop-up, show the pop-up but not require a message, show the pop-up and require a message.

Implementation:

  • add a row in eventlog table to store commit message
  • create the JS pop-up
  • modify event log storage to accept external commit message.

Related issues 9 (0 open9 closed)

Related to Rudder - Bug #2528: Providing a reason for a change should not be mandatory by defaultReleasedJonathan CLARKE2012-06-05Actions
Related to Rudder - Bug #2532: When deleting a Rule, the reason input is not output to the change log in gitReleasedJean VILVER2012-06-05Actions
Related to Rudder - Bug #2533: When "reason" field is optional, a default message is displayedReleasedJean VILVER2012-06-05Actions
Related to Rudder - Bug #2531: Event log column "Cause" should be named "Reason"ReleasedJonathan CLARKE2012-06-05Actions
Has duplicate Rudder - User story #2355: Allow user to add a message when archivingRejectedFrançois ARMAND2012-03-03Actions
Blocked by Rudder - User story #2492: Show a popup input to explain delete or disable in Rules, Directives and Techniques ManagementReleasedJean VILVER2012-05-21Actions
Blocked by Rudder - User story #2493: Add reasons field to Directives edit formReleasedJean VILVER2012-05-21Actions
Blocked by Rudder - User story #2501: Show a popup input to explain move between Reference Technique Library to Reference Active LibraryReleasedJean VILVER2012-05-29Actions
Blocked by Rudder - User story #2494: Add reasons field to groups edit formReleasedJean VILVER2012-05-21Actions
Actions #1

Updated by François ARMAND almost 12 years ago

  • Status changed from 8 to In progress
Actions #2

Updated by François ARMAND almost 12 years ago

All the back-end is up and working since commit ded679c7 :

  • all events leading to and eventlog (and thus all action leading to the serialisation of a Rules/Group/Directive/ActiveTechnique) may be enhanced with a "reason" message
  • that message is store in the database, in column "reason", and so the DB must be updated, see #2489
  • that message is added to the commit message of the corresponding Git Commit (if any), leading to commit message looking like: "Directive XXXXX updated. Reason: User updated the directive with the UI". It was chosen to keep the first, automatic, part of the commit message to keep system information (directive UUID, for example), and be sur to always have a non empty message.

Now, we have to implement the browser (client) part of the feature, to allow user to chose their message.

Actions #3

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from In progress to Released
Actions #4

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from Released to Pending technical review

Oops, this needs a technical review, actually.

Actions #5

Updated by Nicolas CHARLES almost 12 years ago

  • Status changed from Pending technical review to 10

This is valid, however some old text remained from the 2.3 era, as stated in bug #2460

Actions #6

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from 10 to Released

This broadly works as expected, but see #2532 and #2533.

Actions

Also available in: Atom PDF