Architecture (meta) #2279
Shoud we use the TreeWalk.release() method after walking the JGit tree ?
|Category:||Architecture - Refactoring|
|Target version:||Ideas (not version specific)|
The documentation is a bit unclear about the subject; it states clearly that RevWalk should be released after use ( http://wiki.eclipse.org/JGit/User_Guide ) but doesn't state the same for the TreeWalk (actually, it says nothing)
However, there is a release method in this class, so it is interesting to see if it should be invoked
#1 Updated by Jonathan CLARKE about 3 years ago
- Category changed from 13 to Architecture - Refactoring
- Assignee changed from Jonathan CLARKE to François ARMAND
#2 Updated by Jonathan CLARKE almost 3 years ago
- Target version changed from 2.4.0~alpha6 to 2.4.0~alpha7
#3 Updated by François ARMAND almost 3 years ago
- Assignee deleted (
- Target version changed from 2.4.0~alpha7 to Ideas (2.5 specific)
Not the kind of code modification we want to handle know, I thing.
I does not seems to leak as it is, so perhaps we shall think to it again in 2.5 ?