https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182012-02-14T15:38:52ZIssue TrackerRudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=84412012-02-14T15:38:52ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Category</strong> changed from <i>Web - Maintenance</i> to <i>System techniques</i></li><li><strong>Status</strong> changed from <i>2</i> to <i>Discussion</i></li><li><strong>Assignee</strong> set to <i>Jonathan CLARKE</i></li></ul><p>The problem seems to be with the policy.xml of Common: there is some variable in it which are multivalued, not defined in multivalued section.</p>
<p>(see internal archive for multivalued section in subsection, for example old #1416 or #1533)</p>
<p>Adding a <SECTION name="authorizedNetworks" multivalued="true"> around input "ALLOWEDNETWORK" solve the display bug, but I can't say it does not brings other problems.</p> Rudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=84432012-02-14T17:05:41ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>Discussion</i> to <i>In progress</i></li></ul><p>I'm going to add the relevant section, and one versed in CFEngine will have to see if the world does not end after that modification.</p> Rudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=84452012-02-14T17:50:37ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset commit:7f4a95fd1854cb27617c8d6887e7b09f7d5844a5.</p> Rudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=84462012-02-14T18:02:46ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Discussion</i></li><li><strong>Assignee</strong> changed from <i>Jonathan CLARKE</i> to <i>François ARMAND</i></li></ul><p>François ARMAND wrote:</p>
<blockquote>
<p>I'm going to add the relevant section, and one versed in CFEngine will have to see if the world does not end after that modification.</p>
</blockquote>
<p>This modification looks fine. It won't affect the generated promises at all, as we use the variables based solely on their name, not on their section. Reporting used the section names, but all reports use other sections that were already defined.</p>
<p>However, shouldn't you remove "<MULTIVALUED>true</MULTIVALUED>" too? I thought this was deprecated now.</p> Rudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=84472012-02-15T09:11:32ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>Discussion</i> to <i>In progress</i></li></ul><p>Yes, you're right. no other policy.xml has that anymore.</p> Rudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=84482012-02-15T09:12:55ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li></ul><p>Applied in changeset commit:fc82b4d725ce4e3fde4bfe9e7a017547460a046c.</p> Rudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=84882012-02-15T19:03:15ZNicolas CHARLESnicolas.charles@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Released</i></li></ul><p>This is valid, thank you Francois !</p> Rudder - Bug #2258: Event log for changes to Policy Instance Common is incompletehttps://issues.rudder.io/issues/2258?journal_id=93242012-04-25T11:14:15ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Target version</strong> changed from <i>2.4.0~alpha5</i> to <i>2.3.7</i></li></ul><p>This bug also applied to the 2.3 branch, so I've backported the commits.</p>