Bug #2258

Event log for changes to Policy Instance Common is incomplete

Added by Jonathan CLARKE over 2 years ago. Updated about 2 years ago.

Status:Released Start date:2012-02-09
Priority:2 Due date:
Assignee:François ARMAND % Done:

100%

Category:Techniques - Sys & init promis
Target version:2.3.7
Needs translating:No Pull Request:

Description

If I add an allowed network to my Rudder server in http://rudder-snapshot.normation.com/rudder/secure/administration/policyServerManagement, then I look at the event logs, I see the output below.

This is missing multiple values for allowed networks - I actually have 3, but only 1 is displayed.

Screenshot-1.png (70.1 kB) Jonathan CLARKE, 2012-02-09 11:18

Associated revisions

Revision 7f4a95fd
Added by François ARMAND over 2 years ago

Fixes #2258: add missing section declaration around multivalued variables in common/policy.xml

Revision fc82b4d7
Added by François ARMAND over 2 years ago

Fixes #2258: remove deprecated <MULTIVALUED> tag for inputs in common/policy.xml

Revision 5283efa8
Added by François ARMAND about 2 years ago

Fixes #2258: add missing section declaration around multivalued variables in common/policy.xml
(cherry picked from commit 7f4a95fd1854cb27617c8d6887e7b09f7d5844a5)

Signed-off-by: Jonathan Clarke <>

Revision deb7a6d5
Added by François ARMAND about 2 years ago

Fixes #2258: remove deprecated <MULTIVALUED> tag for inputs in common/policy.xml
(cherry picked from commit fc82b4d725ce4e3fde4bfe9e7a017547460a046c)

Signed-off-by: Jonathan Clarke <>

Revision c216a420
Added by Nicolas PERRON about 2 years ago

Merge branch 'branches/rudder/2.3' into branches/rudder/2.4

  • branches/rudder/2.3:
    Fixes #2454: The jobScheduler PT is now completely multivaluation compliant (reports and policy.xml adjusted)
    Fixes #2470: Added the binary comparison method in copyGitFile that was missing, and corrected the configuration statement description
    Fix reporting for post-hook in PT fileManagement. Fixes #2481
    Refs #2465: Added a MAYBEEMPTY var on checkGenericFileContent to make the file content part optionnal
    Fixes #2465: Adjusted checkGenericFileContent reports because of an extra report that should not be here
    Fixes #2467 : allowing to create a group and edit it in the same run
    Fixes #2465: The does not have a mandatory field to enforce file content anymore
    Fixes #2258: remove deprecated <MULTIVALUED> tag for inputs in common/policy.xml (cherry picked from commit fc82b4d725ce4e3fde4bfe9e7a017547460a046c)
    Fixes #2258: add missing section declaration around multivalued variables in common/policy.xml (cherry picked from commit 7f4a95fd1854cb27617c8d6887e7b09f7d5844a5)
    Fixes #2343 : correct the version of cfengine in the requierement (cherry picked from commit f5e924930e7a185d4536c7b434dd829fe2736766)
    Refs #2435 Change success report condition in aptPackageManagerSettings
    TRIVIAL: Adding comments on reporting in aptPackageManagerSettings
    Fixes #2467 : correct the reporting in the PT Group Management

Conflicts:
techniques/systemSettings/userManagement/groupManagement/1.0/groupManagement.st

Revision b5c12eda
Added by Nicolas PERRON about 2 years ago

Merge branch 'branches/rudder/2.4'

  • branches/rudder/2.4:
    Refs #2465 Change path and policy references in order to be 2.4+ compliant
    Fixes #2454: The jobScheduler PT is now completely multivaluation compliant (reports and policy.xml adjusted)
    Fixes #2470: Added the binary comparison method in copyGitFile that was missing, and corrected the configuration statement description
    Fix reporting for post-hook in PT fileManagement. Fixes #2481
    Refs #2465: Added a MAYBEEMPTY var on checkGenericFileContent to make the file content part optionnal
    Fixes #2465: Adjusted checkGenericFileContent reports because of an extra report that should not be here
    Fixes #2467 : allowing to create a group and edit it in the same run
    Fixes #2465: The does not have a mandatory field to enforce file content anymore
    Fixes #2258: remove deprecated <MULTIVALUED> tag for inputs in common/policy.xml (cherry picked from commit fc82b4d725ce4e3fde4bfe9e7a017547460a046c)
    Fixes #2258: add missing section declaration around multivalued variables in common/policy.xml (cherry picked from commit 7f4a95fd1854cb27617c8d6887e7b09f7d5844a5)
    Fixes #2343 : correct the version of cfengine in the requierement (cherry picked from commit f5e924930e7a185d4536c7b434dd829fe2736766)
    Refs #2435 Change success report condition in aptPackageManagerSettings
    TRIVIAL: Adding comments on reporting in aptPackageManagerSettings
    Fixes #2467 : correct the reporting in the PT Group Management

History

#1 Updated by François ARMAND over 2 years ago

  • Category changed from Webapp - Administration to Techniques - Sys & init promis
  • Status changed from 2 to Discussion
  • Assignee set to Jonathan CLARKE

The problem seems to be with the policy.xml of Common: there is some variable in it which are multivalued, not defined in multivalued section.

(see internal archive for multivalued section in subsection, for example old #1416 or #1533)

Adding a <SECTION name="authorizedNetworks" multivalued="true"> around input "ALLOWEDNETWORK" solve the display bug, but I can't say it does not brings other problems.

#2 Updated by François ARMAND over 2 years ago

  • Status changed from Discussion to In progress

I'm going to add the relevant section, and one versed in CFEngine will have to see if the world does not end after that modification.

#3 Updated by François ARMAND over 2 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:7f4a95fd1854cb27617c8d6887e7b09f7d5844a5.

#4 Updated by Jonathan CLARKE over 2 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to François ARMAND

François ARMAND wrote:

I'm going to add the relevant section, and one versed in CFEngine will have to see if the world does not end after that modification.

This modification looks fine. It won't affect the generated promises at all, as we use the variables based solely on their name, not on their section. Reporting used the section names, but all reports use other sections that were already defined.

However, shouldn't you remove "<MULTIVALUED>true</MULTIVALUED>" too? I thought this was deprecated now.

#5 Updated by François ARMAND over 2 years ago

  • Status changed from Discussion to In progress

Yes, you're right. no other policy.xml has that anymore.

#6 Updated by François ARMAND over 2 years ago

  • Status changed from In progress to Pending technical review

Applied in changeset commit:fc82b4d725ce4e3fde4bfe9e7a017547460a046c.

#7 Updated by Nicolas CHARLES over 2 years ago

  • Status changed from Pending technical review to Released

This is valid, thank you Francois !

#8 Updated by Jonathan CLARKE about 2 years ago

  • Target version changed from 2.4.0~alpha5 to 2.3.7

This bug also applied to the 2.3 branch, so I've backported the commits.

Also available in: Atom PDF