Project

General

Profile

Actions

Bug #2199

closed

Git commit error on auto-archive should be a system error in log, not a user one

Added by François ARMAND about 12 years ago. Updated about 12 years ago.

Status:
Released
Priority:
3
Category:
Web - Maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The rational behind that is:

  • the user see a "save PI error: file was not saved in Git", or "moving group error: file was not saved in Git", or other error like that but he can't do anything - and taking the same action will show the same error
  • modification on the PI/Group/CR etc are already commited in the LDAP, and can't be easely rollbacked
  • XML archiving in the FS managed by Git is more a system settings than one up to the user setting a description to a group.

So, the idea will be to log these error the application log in place of having them poping into user face.

Actions #1

Updated by François ARMAND about 12 years ago

  • Target version changed from 2.4.0~alpha4 to 2.4.0~alpha5
Actions #2

Updated by François ARMAND about 12 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 0 to 100

Done in commit ad6fddd8

Actions #3

Updated by Nicolas CHARLES about 12 years ago

  • Status changed from Pending technical review to In progress
  • % Done changed from 100 to 90

This does look valid, but an error shouldn't be logged in a logger.error rather than a logger.debug ??

Actions #4

Updated by François ARMAND about 12 years ago

That's right, it makes more sense to log them in error.

Actions #5

Updated by François ARMAND about 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 90 to 100
Actions #6

Updated by Nicolas CHARLES about 12 years ago

  • Status changed from Pending technical review to Released

Thank you Francois

Actions

Also available in: Atom PDF