Bug #2142

/etc/init.d/rudder-server-root exists on Debian, not on SLES

Added by Nicolas PERRON over 3 years ago. Updated 6 months ago.

Status:ReleasedStart date:2011-12-23
Priority:2Due date:
Assignee:Nicolas PERRON% Done:

100%

Category:Packaging
Target version:2.3.7
Pull Request: How to reproduce:

Reproduced: Found in version(s):

Associated revisions

Revision 63edf9a8
Added by Nicolas PERRON over 3 years ago

Fixes #2142 RPM packages have now rudder-server-root too

Revision fae0b149
Added by Nicolas PERRON over 3 years ago

Refs #2142 Add localclean instructions into Makefile of rudder-server-root

Revision b10178f0
Added by Jonathan CLARKE over 3 years ago

Merge branch 'branches/rudder/2.3'

  • branches/rudder/2.3:
    Fixes #2142 RPM packages have now rudder-server-root too

Conflicts:
rudder-server-root/SOURCES/Makefile

Revision 72c299ce
Added by Nicolas PERRON over 3 years ago

Refs #2142 rudder-server-root.init is targeted by localdepends now

Revision ec2cb9e0
Added by Jonathan CLARKE over 3 years ago

Merge branch 'branches/rudder/2.3'

  • branches/rudder/2.3:
    Refs #2142 rudder-server-root.init is targeted by localdepends now
    Refs #2142 Add localclean instructions into Makefile of rudder-server-root

Conflicts:
rudder-server-root/SOURCES/Makefile

History

#1 Updated by Jonathan CLARKE over 3 years ago

  • Target version changed from 2.3.6 to 2.3.7

#2 Updated by Nicolas PERRON over 3 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:63edf9a8ccfe53d64711a618c8fa7ee46c5c3b1f.

#3 Updated by Jonathan CLARKE over 3 years ago

  • Status changed from Pending technical review to In progress
  • % Done changed from 100 to 90

This looks good, aside from one detail: when you create files in the Makefile, please remember to clean them up too! You should add a rm -f command to the localclean: target for the init script you copy into debian/.

#4 Updated by Jonathan CLARKE over 3 years ago

While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.

#5 Updated by Jonathan CLARKE over 3 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 90 to 100

Applied in changeset commit:b10178f0d51df945936e766f84d7100375dd1ad1.

#6 Updated by Jonathan CLARKE over 3 years ago

  • Status changed from Pending technical review to 2

Whoops, this was merged but still needs fixing!

#7 Updated by Nicolas PERRON over 3 years ago

  • Status changed from 2 to Pending technical review

#8 Updated by Jonathan CLARKE over 3 years ago

  • Status changed from Pending technical review to 2
  • % Done changed from 100 to 90

Jonathan CLARKE wrote:

While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.

Please address this comment.

#9 Updated by Nicolas PERRON over 3 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 90 to 100

Jonathan CLARKE wrote:

Jonathan CLARKE wrote:

While merging this commit to master, I noticed that you added a target to the Makefile (../debian/rudder-server-root.init) but you didn't add it the the localdepends: target, so it won't be called.

Please address this comment.

This is repaired

#10 Updated by Jonathan CLARKE over 3 years ago

  • Status changed from Pending technical review to Released

Thanks, looks good now

#11 Updated by Nicolas PERRON over 2 years ago

  • Project changed from Rudder to packages
  • Category deleted (11)

#12 Updated by Benoît PECCATTE 6 months ago

  • Project changed from packages to Rudder
  • Category set to Packaging

Also available in: Atom PDF