Project

General

Profile

Bug #1884

The addupdate target on the package installation Technique is broken. We should enable it again when possible

Added by Matthieu CERDA over 4 years ago. Updated 23 days ago.

Status:
Discussion
Priority:
4
Category:
Techniques
Target version:
Start date:
2011-09-30
Due date:
% Done:

0%

Pull Request:
Reproduced:
How to reproduce:
Found in version(s):
Tags: Quick and important

Description

The addupdate target on the package installation PT is broken. We should enable it again when possible


Related issues

Related to Rudder - User story #4298: Install / upgrade packages New 2013-12-30
Duplicated by Rudder - Bug #6957: You can't do install+update in one shot in the install package technique Rejected 2015-07-10

History

#2 Updated by Jonathan CLARKE over 4 years ago

  • Target version set to 18

#3 Updated by François ARMAND over 4 years ago

  • Target version changed from 18 to 2.4.0~alpha1

#4 Updated by Jonathan CLARKE over 4 years ago

  • Target version changed from 2.4.0~alpha1 to 2.4.0~alpha2

#5 Updated by Jonathan CLARKE over 4 years ago

  • Target version changed from 2.4.0~alpha2 to 2.4.0~alpha3

#6 Updated by Matthieu CERDA over 4 years ago

  • Status changed from New to Discussion

This still seems broken in CFengine, no class gets raised when the package is already installed and up to date.

rudder> Checking if package (nano,*,*) is at the desired state (installed=1,matched=1)
rudder>  -> Package promises to refer to itself as "nano" to the manager
rudder>  -> Package version seems to match criteria
rudder> Checking if latest available version is newer than installed...
rudder> Looking for an installed package older than (nano,*,*)
rudder> Found installed package (nano,2.2.4-1,default)
rudder> Installed package is up to date, not updating

For reference, here is the add flavor output :

rudder> Checking if package (nano,*,*) is at the desired state (installed=1,matched=1)
rudder>  -> Package promises to refer to itself as "nano" to the manager
rudder>  -> Package version seems to match criteria
rudder>  -> Package "nano" already installed, so we never add it again
rudder>  ?> defining promise result class debian_install_kept_nano

#7 Updated by Jonathan CLARKE over 4 years ago

  • Target version changed from 2.4.0~alpha3 to 2.4.0~alpha4

#8 Updated by François ARMAND about 4 years ago

  • Target version changed from 2.4.0~alpha4 to 2.4.0~alpha5

#9 Updated by Jonathan CLARKE about 4 years ago

  • Target version changed from 2.4.0~alpha5 to 2.4.0~alpha6

#10 Updated by Jonathan CLARKE about 4 years ago

  • Target version changed from 2.4.0~alpha6 to 2.4.0~alpha7

#11 Updated by Jonathan CLARKE about 4 years ago

  • Target version changed from 2.4.0~alpha7 to 2.3.8

#12 Updated by Jonathan CLARKE almost 4 years ago

  • Target version changed from 2.3.8 to 24

#13 Updated by Jonathan CLARKE almost 4 years ago

  • Target version changed from 24 to Ideas (not version specific)

#14 Updated by Nicolas CHARLES over 1 year ago

  • Status changed from Discussion to 8
  • Assignee set to Nicolas CHARLES
  • Target version changed from Ideas (not version specific) to 2.10.8

i hope it's been fixed in CFEngine

#15 Updated by Nicolas CHARLES over 1 year ago

Ok, this is actually like the standart update: we cannot simply latest to have latest version
We have a nice solution on RPM, so i'll be using it on RPM
It has not yet been implemented on DEB however

#16 Updated by Nicolas CHARLES over 1 year ago

hum, i've been a bit optimisstic
addupdate still doesn't work as expected... i get always repaired state, or no reports

trying to tinker with it, forcing target version when available, or considering it as an update all fails

#17 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 2.10.8 to 2.10.9

#18 Updated by Jonathan CLARKE over 1 year ago

The link to the old bugtracker has been updated: http://auth.cfengine.com/bugtracker/view.php?id=532

It seems we need to define a specific classes body with return code outcomes for this to work. Could you test again?

#19 Updated by Nicolas CHARLES over 1 year ago

addupdate is more broken than that: it simply does not install if you specify a target version and package was not there, it does not update if it is installed

#20 Updated by Nicolas CHARLES over 1 year ago

but we could "simply" convert the addupdate to "install" and then "update", and aggregate the reports from both

#21 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 2.10.9 to 2.10.10

#22 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 2.10.10 to 2.10.11

#23 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 2.10.11 to 2.10.12

#24 Updated by Benoît PECCATTE about 1 year ago

  • Project changed from Techniques to Rudder
  • Category changed from Policy Templates to Techniques

#25 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 2.10.12 to 2.10.13

#26 Updated by Benoît PECCATTE about 1 year ago

  • Status changed from 8 to New

#27 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 2.10.13 to 2.10.14

#28 Updated by Vincent MEMBRÉ 12 months ago

  • Target version changed from 2.10.14 to 2.10.15

#29 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 2.10.15 to 2.10.16

#30 Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 2.10.16 to 2.10.17

#31 Updated by Jonathan CLARKE 9 months ago

  • Subject changed from The addupdate target on the package installation PT is broken. We should enable it again when possible to The addupdate target on the package installation Technique is broken. We should enable it again when possible

#32 Updated by Jonathan CLARKE 9 months ago

  • Duplicated by Bug #6957: You can't do install+update in one shot in the install package technique added

#33 Updated by Jonathan CLARKE 9 months ago

#34 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 2.10.17 to 2.10.18

#35 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 2.10.18 to 2.10.19

#36 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 2.10.19 to 2.10.20

#37 Updated by Vincent MEMBRÉ 5 months ago

  • Target version changed from 2.10.20 to 2.11.18

#38 Updated by Jonathan CLARKE 3 months ago

  • Tags set to Quick and important
  • Assignee changed from Nicolas CHARLES to Alexis MOUSSET

Marking this as "Quick and important" because it is quick to test whether this now works as expected, at least in CFEngine 3.6 or 3.7.

Alexis, can you please do this test, and check the result classes. If it works in any given version, let's enable it there, because this is a key feature to have disabled :(

If you can see a way of fixing it in earlier versions, that would be a huge bonus, too.

#39 Updated by Alexis MOUSSET 3 months ago

  • Status changed from New to In progress

Matthieu CERDA wrote:

This still seems broken in CFengine, no class gets raised when the package is already installed and up to date.
[...]

This should be fixed since #6996, testing in 2.11.

#40 Updated by Alexis MOUSSET 3 months ago

Seems to work well when adding the mechanism we use for updates to detect new versions.

Tested on Centos 6, Rudder 3.1

Only a little reporting issue:

R: @@packageInstallation@@result_repaired@@32377fd7-02fd-43d0-aab7-28460a91347b@@1117c83d-b78e-4883-b737-7ae90825846e@@7@@RHEL/CentOS/SuSE packages@@nmap@@2016-01-19 12:06:58+00:00##root@#Performed repair action for RPM package nmap to comply with policy: addupdate
R: @@packageInstallation@@result_success@@32377fd7-02fd-43d0-aab7-28460a91347b@@1117c83d-b78e-4883-b737-7ae90825846e@@7@@RHEL/CentOS/SuSE packages@@nmap@@2016-01-19 12:06:58+00:00##root@#No action required for RPM package nmap with policy: addupdate

#41 Updated by Alexis MOUSSET 3 months ago

The reporting problems seems to be #7623, which is already fixed!

#42 Updated by Jonathan CLARKE 3 months ago

Excellent news! Can you confirm it also works well on apt systems?

If so, let's make a simple PR to reenable this ASAP. We may need to check behaviour on Rudder 2.10, because a 2.11 server can still have 2.10 agents.

#43 Updated by Alexis MOUSSET 3 months ago

Update without specified version won't work on apt systems, but it is currently the case for simple update too (#6994).

#44 Updated by Alexis MOUSSET 3 months ago

I am testing the change on RPM systems on 2.10, 2.11 and 3.1.

#45 Updated by Alexis MOUSSET 3 months ago

Finally not as easy as it seemed, we will have to split the cases to use the update mechanism in the technique (and also lose the benefits of addupdate).

#46 Updated by Vincent MEMBRÉ 3 months ago

  • Target version changed from 2.11.18 to 2.11.19

#47 Updated by Alexis MOUSSET 3 months ago

  • Status changed from In progress to Discussion

#48 Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 2.11.19 to 2.11.20

#49 Updated by Vincent MEMBRÉ 23 days ago

  • Target version changed from 2.11.20 to 2.11.21

Also available in: Atom PDF