User story (meta) #1848

Escape special characters like ' " or ! in directive values

Added by Nicolas PERRON about 3 years ago. Updated over 1 year ago.

Status:Rejected Start date:2011-09-26
Priority:3 Due date:
Assignee:- % Done:

0%

Category:Webapp - Config management
Target version:Ideas (not version specific)
Needs translating:No

Description

I kept breaking my Rudder by setting a MOTD with double quotes in. We added a regex validator like "([^"]|(?<=\\)")*" to one PT to disallow quotes unless they're escaped, but it's a bit of a hack...

In a more global frame, this should probably be applied automatically to almost all input passed to CFEngine...


Related issues

related to Techniques - Bug #2170: MOTD PT should validate the MOTD value with a regex Released 2012-01-12
related to Techniques - User story (meta) #2887: Add a warning in the checkGenericFileContent Technique ab... Released 2012-09-10
related to Rudder - Bug #3108: break rules generation using quotes in a "File content" i... Rejected 2012-12-27
duplicated by Rudder - Bug #2823: Some special characters seems to not be escaped in MOTD T... Rejected 2012-08-17

History

#1 Updated by Jonathan CLARKE about 3 years ago

  • Target version changed from 23 to Ideas (2.4 specific)

#2 Updated by François ARMAND almost 3 years ago

  • Target version changed from Ideas (2.4 specific) to Ideas (2.5 specific)

#3 Updated by Jonathan CLARKE over 2 years ago

  • Tracker changed from Bug to User story (meta)
  • Subject changed from MOTD Policy Instance can't escape characters like ' " or ! to Escape special characters like ' " or ! in directive values
  • Description updated (diff)
  • Priority changed from 4 to 3
  • Target version changed from Ideas (2.5 specific) to Ideas (not version specific)
  • Needs translating set to No

#4 Updated by Michael Gliwinski about 2 years ago

  • 2 set to 0

I just ran into this in checkGenericFileContent technique.

It appears #2947 is related too.

#5 Updated by Nicolas CHARLES over 1 year ago

  • Status changed from New to Rejected

I'm rejecting as a duplicated of #2947

Also available in: Atom PDF