User story #1848

Escape special characters like ' " or ! in directive values

Added by Nicolas PERRON almost 4 years ago. Updated over 2 years ago.

Status:RejectedStart date:2011-09-26
Priority:3Due date:
Assignee:-% Done:

0%

Category:Web - Config management
Target version:Ideas (not version specific)
Pull Request:

Description

I kept breaking my Rudder by setting a MOTD with double quotes in. We added a regex validator like "([^"]|(?<=\\)")*" to one PT to disallow quotes unless they're escaped, but it's a bit of a hack...

In a more global frame, this should probably be applied automatically to almost all input passed to CFEngine...


Related issues

Related to Rudder - Bug #2170: MOTD PT should validate the MOTD value with a regex Released 2012-01-12
Related to Rudder - Bug #3108: break rules generation using quotes in a "File content" i... Rejected 2012-12-27
Related to Rudder - User story #2887: Add a warning in the checkGenericFileContent Technique ab... Released 2012-09-10
Duplicated by Rudder - Bug #2823: Some special characters seems to not be escaped in MOTD T... Rejected 2012-08-17

History

#1 Updated by Jonathan CLARKE almost 4 years ago

  • Target version changed from 23 to 18

#2 Updated by François ARMAND almost 4 years ago

  • Target version changed from 18 to 24

#3 Updated by Jonathan CLARKE over 3 years ago

  • Tracker changed from Bug to User story
  • Subject changed from MOTD Policy Instance can't escape characters like ' " or ! to Escape special characters like ' " or ! in directive values
  • Description updated (diff)
  • Priority changed from 4 to 3
  • Target version changed from 24 to Ideas (not version specific)

#4 Updated by Michael Gliwinski almost 3 years ago

I just ran into this in checkGenericFileContent technique.

It appears #2947 is related too.

#5 Updated by Nicolas CHARLES over 2 years ago

  • Status changed from New to Rejected

I'm rejecting as a duplicated of #2947

Also available in: Atom PDF